Conversation
eldadfux
reviewed
Oct 17, 2024
eldadfux
requested changes
Oct 29, 2024
composer.json
Outdated
Comment on lines
36
to
40
| "repositories": { | ||
| "utopia-php/compression": { | ||
| "type": "git", | ||
| "url": "https://github.com/utopia-php/compression" | ||
| } |
Member
There was a problem hiding this comment.
This can be removed now that the package was published.
Member
There was a problem hiding this comment.
I think the filename/location is not consistent with what we do in other utopia libs. Maybe we can use the database library or something else for a pattern we can reuse here.
Contributor
Author
There was a problem hiding this comment.
Do you like this?
tests/
e2e/
Server/
SwooleTest.php
FPMTest.php
SwooleCompressionTest.php
...
resources/
init.php
SwooleServer.php
FPMServer.php
SwooleCompressionServer.php
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
setCompressionconfiguration method to utopia HttpIf enabled, this performs brotli, gzip, or delate (in decreasing priority) compression on response bodies of requests that:
text/*etc)accept-encodingheader